Screenshot Shortcuts and Code Cleaning #562
Conversation
|
@diasdavid AFAIK, Electron can't get selected text on screen that's not inside electron's view due to security reasons. The same happens to files: I can't know if the keys were pressed when selecting files so I don't think it is possible to create those shortcuts right now, but I'll investigate a bit more. |
|
@diasdavid could you take a look at the code? I'm thinking of merging this and do the other two shortcuts for later (when it's possible or when I find a solution). |
hacdias
force-pushed
the
feat/kb-shortcuts
branch
from
f39e0fe
to
f1be3d8
Compare
style: cleanup code register shortcuts screenshot working; clean main controls move filehistory handlers to controls make renderer controls similar to main's take screenshot cleaning config more cleaning remove blank space dont let users select text improve transitions remove shortcuts
hacdias
force-pushed
the
feat/kb-shortcuts
branch
from
f1be3d8
to
cb72389
Compare
hacdias
changed the title
src/config.js
Outdated
| process.on('uncaughtException', (error) => { | ||
| const msg = error.message || error | ||
| logger.error(`Uncaught Exception: ${msg}`, error) | ||
| dialog.showErrorBox('Uncaught Exception:', msg) |
There was a problem hiding this comment.
This error box should guide the user to the issue tracker (this repo) and recommend to open a issue with the error
There was a problem hiding this comment.
Will do this tomorrow or sunday.
src/config.js
Outdated
| require('electron').crashReporter.start({ | ||
| productName: 'Station', | ||
| companyName: 'IPFS', | ||
| submitURL: 'https://ipfs.io', |
There was a problem hiding this comment.
This is submitting nothing to nowhere. I'll remove this. It seems to be here since the 'old days' 😛
Upload File ShortcutDownload selected hash shortcut