-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve UI when user tries to open missing file #961
Comments
I think a 404-like page, tailoured for the files page would be useful. An individual user may bookmark a location and then move things around. TODO:
Bonus pointswhat if we include the CID info in the url? This would allow us to:
|
@hklcf those errors are not related to this issue: those are just missing translation for @jessicaschilling thoughts on improving the 404 "Not found" state of Files screen? It should be more prominent, and also more explicit:
As a data point, currentversion of "404" screen from a user report copied from ipfs/kubo#7604:
Right now user is unable to tell what went wrong and why "404" is displayed. |
@lidel Rough first pass at what this might look like if we used the same visual language as the "not connected" errors that will ship in 2.11. Suggesting we use those visuals for consistency, but would appreciate advice for improving the text. |
@rafaelramalho19 raised the problem of having two types of "not found" errors:
I believe if we implement separate screens for each, then (1) should have super breadcrumbs, so it's easy for user to go up in MFS until an existing item works. For additional ✨ each "missing" crumb would be in red. This may be additional work, so if its easier to do a quick fix by showing the same page for (1) and (2), I would do that (just a plain error without Files-specific UI). |
@lidel That all makes sense - are you OK with the proposed text in the mockup? If so I think this is ready to build. |
Having a separate page handler for both the errors is the simplest and cleanest solution, here's my points: Pros:
Cons:
|
If we remove the Files-specific UI elements per #961 (comment) (image), then we don't include breadcrumbs at all. |
If breadcrumbs can't be reused easily, then I'd go with Jessica's sugegstion from the comment above and remove files-specific UI. |
@rafaelramalho19 Text follows, including edits discussed out-of-band: IPFS can't find this item These common troubleshooting steps might help:
{button}Back to Files{/button} |
I do not know if it is related to this but on my website I have a problem of that style. |
@wuniversales this is unrelated, but you should use |
|
"Not Found" error for Files tab could be better :-)
Open http://127.0.0.1:8080/ipfs/QmXc9raDM1M5G5fpBnVyQ71vR4gbnskwnB9iMEzBuLgvoZ/#/files/I_AM_NOT_HERE.jpg (or any other filename that is not present in your MFS)
See this odd state with no buttons and bogus error about adding:
![image](https://user-images.githubusercontent.com/1507828/92288669-dd30f880-eeca-11ea-9c63-c5aca4e9c861.png)
This may happen if someone bookmarks or copies URL to another machine without pointing webui at the same IPFS node.
We should either display a meaningful message or just silently redirect to the nearest MFS root.
Tasks
The text was updated successfully, but these errors were encountered: