Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Storybook 5 #986

Closed
fsdiogo opened this issue Mar 11, 2019 · 4 comments
Closed

Update to Storybook 5 #986

fsdiogo opened this issue Mar 11, 2019 · 4 comments
Assignees
@fsdiogo

Comments

@fsdiogo
Copy link
Contributor

fsdiogo commented Mar 11, 2019

Update to the shiny Storybook 5 🌟

https://medium.com/storybookjs/storybook-5-0-db1d0f9c83b8
@fsdiogo fsdiogo self-assigned this Mar 11, 2019
@olizilla olizilla mentioned this issue Mar 11, 2019
Closed
10 tasks
@fsdiogo fsdiogo mentioned this issue Mar 11, 2019
Closed
@olizilla
Copy link
Member

Let's make sure we build and publish the storybook somewhere. I could be as simple as /storybook

@cwaring
Copy link
Member

cwaring commented Mar 11, 2019 via email

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Mar 12, 2019

@cwaring I think we do, as we have some whole pages in Storybook to check their state.

The individual components can be extracted to be component library, but I guess that we'll still have some to show in the Web UI storybook.

@olizilla
Copy link
Member

Let's have both!

@fsdiogo fsdiogo mentioned this issue Mar 12, 2019
Merged
@fsdiogo fsdiogo added the status/in-progress In progress label Mar 12, 2019
@fsdiogo fsdiogo closed this as completed Mar 19, 2019
@ghost ghost removed the status/in-progress In progress label Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fsdiogo fsdiogo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@olizilla @cwaring @fsdiogo