Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: local peers display #1323

Merged
merged 2 commits into from Nov 20, 2019
Merged

fix: local peers display #1323

merged 2 commits into from Nov 20, 2019

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Nov 19, 2019

Basically this was failing because I set it to "fail" if we couldn't determine the public IP and thus it wouldn't even check if the IP was private or not.

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm (confirmed IP from hotel LAN):
2019-11-19_23-41

@hacdias hacdias merged commit b0f7792 into master Nov 20, 2019
@hacdias hacdias deleted the fix/local-peers branch November 20, 2019 14:07
@hacdias hacdias mentioned this pull request Dec 4, 2019
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants