chore: update dependencies #1552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hacdias
reviewed
Jul 22, 2020
There was a problem hiding this comment.
The dependencies update looks good. I'm having some issues but I can't guarantee it's the dependencies fault. I'm running the latest IPFS Desktop version. The issues:
- When adding a file through "Import" on the root MFS, it works.
- When adding a file through "Import" on any subdirectory,
API returned a partial response. - When adding a directory through "Import", same error as above.
- Drag&drop works everywhere.
- Everything I click gets an outline.
- When I rename a file and I'm on the same page as the file, it doesn't redirect and opens the "Imported x files" dialog.
Is that replicable in the default branch? |
hacdias
approved these changes
Jul 22, 2020
There was a problem hiding this comment.
@rafaelramalho19 yes, they're reproducible on master. This seems good to go then.
jessicaschilling
approved these changes
Jul 22, 2020
|
Thank you for testing that @hacdias, maybe we should open issues with the problems you found? 馃 |
This was referenced Apr 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested everything in webui and seems to be working fine. But I might of missed some edge-cases so please help 馃檹