Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add cube animation as loading indicator #1570

Merged
merged 1 commit into from Aug 3, 2020
Merged

feat: add cube animation as loading indicator #1570

merged 1 commit into from Aug 3, 2020

Conversation

rafaelramalho19
Copy link
Contributor

Note

  • If you want to test this, you should probably throttle your connection to slow or fast 3G 馃槃

Screen-Recording-2020-07-30-at-1

  • I had to convert this animation to CSS only, so it can work while the JS is being parsed/downloaded.

@rafaelramalho19 rafaelramalho19 self-assigned this Jul 30, 2020
jessicaschilling
jessicaschilling approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@jessicaschilling jessicaschilling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool 馃槉

@jessicaschilling jessicaschilling mentioned this pull request Jul 30, 2020
Closed
lidel
lidel approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

src/loader/ComponentLoader.stories.js Show resolved Hide resolved
@jessicaschilling jessicaschilling merged commit fee6744 into master Aug 3, 2020
@jessicaschilling jessicaschilling deleted the feat/loading-indicator branch August 3, 2020 19:50
This was referenced Apr 3, 2021
Open
Open
@snyk-bot snyk-bot mentioned this pull request Dec 14, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@jessicaschilling jessicaschilling jessicaschilling approved these changes

@olizilla olizilla Awaiting requested review from olizilla

Assignees

@rafaelramalho19 rafaelramalho19

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rafaelramalho19 @lidel @jessicaschilling