Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not show api address form on Desktop #1835

Merged
merged 1 commit into from Sep 2, 2021
Merged

fix: do not show api address form on Desktop #1835

merged 1 commit into from Sep 2, 2021

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Aug 14, 2021 •
edited by lidel

Disable the API address form on IPFS Desktop.

Implements the first TODO from ipfs/ipfs-desktop#1888 (comment)

Note: this is needed: ipfs/ipfs-desktop#1894

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

@hacdias
fix: do not show api address form on Desktop
aff552a 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias hacdias requested a review from lidel August 14, 2021 09:18
@hacdias hacdias added this to In Review in Maintenance Priorities - JS via automation Aug 14, 2021
@hacdias hacdias temporarily deployed to Deploy August 14, 2021 09:23 Inactive
@hacdias hacdias self-assigned this Aug 17, 2021
@hacdias hacdias added kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up P2 Medium: Good to have, but can wait until someone steps up area/screen/settings Issues related to Settings screen effort/hours Estimated to take one or several hours kind/enhancement A net-new feature or improvement to an existing feature and removed P1 High: Likely tackled by core team if no one steps up kind/bug A bug in existing code (including security flaws) labels Aug 17, 2021
@lidel lidel added the status/blocked Unable to be worked further until needs are met label Aug 18, 2021
lidel
lidel requested changes Aug 18, 2021
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, but we need to figure out ipfs/ipfs-desktop#1894 (review) before this is safe to merge

@hacdias hacdias moved this from In Review to Parked/Blocked in Maintenance Priorities - JS Aug 19, 2021
@hacdias hacdias moved this from Parked/Blocked to In Review in Maintenance Priorities - JS Aug 19, 2021
@hacdias hacdias requested a review from lidel September 2, 2021 13:05
@hacdias
Copy link
Member Author

hacdias commented Sep 2, 2021

@lidel the blocking PR was merged :)

@lidel lidel mentioned this pull request Sep 2, 2021
Closed
lidel
lidel approved these changes Sep 2, 2021
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this covers the first TODO from ipfs/ipfs-desktop#1888 (comment) and should be good enough for now.

I'm keeping mentioned issue open until we have time to verify if there is anything to be done around $IPFS_PATH/api

@lidel lidel merged commit 149e003 into main Sep 2, 2021
@lidel lidel deleted the fix/do-not-show-api-desktop branch September 2, 2021 15:13
Maintenance Priorities - JS automation moved this from In Review to Done Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@rafaelramalho19 rafaelramalho19 Awaiting requested review from rafaelramalho19

Assignees

@hacdias hacdias

Labels
area/screen/settings Issues related to Settings screen effort/hours Estimated to take one or several hours kind/enhancement A net-new feature or improvement to an existing feature P2 Medium: Good to have, but can wait until someone steps up status/blocked Unable to be worked further until needs are met
Projects
No open projects
IP JS (PL EngRes) v2
Archived in project
Maintenance Priorities - JS
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hacdias @lidel