feat: check if gateway is valid using image #1846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Henrique Dias <hacdias@gmail.com>
lidel
approved these changes
Sep 2, 2021
There was a problem hiding this comment.
LGTM. 👍
I think checking on submit is perfectly fine for basic sanity check that protects users against URL that does not act as a gateway.
We could check on every change, but then we have to add "Testing..." status that disables submit button until test is done + account for various edge cases. Fine to do this as follow-up PR, but i'm merging this as-is because it's already an improvement ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1844 by using the same code we use in Companion (check mentioned issue).
It verifies if the gateway is valid only when submitting. I feel like validating on change would be better in terms of UX, but it can also be problematic as we have a 15 seconds timeout to account for the gateway to fetch the actual content.
License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com