Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ux improvements to publish modal #1998

Merged
merged 9 commits into from
Aug 9, 2022
Merged

feat: ux improvements to publish modal #1998

merged 9 commits into from
Aug 9, 2022

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Aug 4, 2022

Closes #1993

When it finishes publishing:

image

After clicking:

image

Then the icon goes back to normal after 2 seconds.

@hacdias hacdias added this to In Review in Maintenance Priorities - JS via automation Aug 4, 2022
@hacdias hacdias temporarily deployed to Deploy August 4, 2022 09:32 Inactive
@hacdias hacdias marked this pull request as draft August 4, 2022 09:37
@hacdias hacdias temporarily deployed to Deploy August 4, 2022 09:41 Inactive
@hacdias hacdias marked this pull request as ready for review August 4, 2022 09:45
@lidel
Copy link
Member

lidel commented Aug 4, 2022

cc @juliaxbow for 👀

@juliaxbow
Copy link
Collaborator

Minor changes to the success state after clicking the copy icon:

  • Icon: padding to the right of the success icon should be increased by 3px to match copy icon formatting
  • Link field: opacity of text or fill of #ffffff at 60% opacity should occur alongside the success message so that it is more legible
  • Success message: I think the tone of "Link copied!" over "Link copied" fits better

Screen Shot 2022-08-04 at 1 20 23 PM

@hacdias hacdias temporarily deployed to Deploy August 8, 2022 09:38 Inactive
@hacdias
Copy link
Member Author

hacdias commented Aug 8, 2022

I addressed @juliaxbow's comments and removed the 'Cancel' button after publishing as it does not do anything different than 'Done'.

Screen.Recording.2022-08-08.at.11.42.29.mov

@hacdias hacdias temporarily deployed to Deploy August 8, 2022 09:46 Inactive
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@lidel lidel merged commit ea4f632 into main Aug 9, 2022
Maintenance Priorities - JS automation moved this from In Review to Done Aug 9, 2022
@lidel lidel deleted the feat/1993 branch August 9, 2022 18:56
ipfs-gui-bot pushed a commit that referenced this pull request Sep 9, 2022
## [2.18.0](v2.17.3...v2.18.0) (2022-09-09)

 CID `bafybeidb5eryh72zajiokdggzo7yct2d6hhcflncji5im2y5w26uuygdsm`

 ---

### Features

* IPNS Publishing ([#1973](#1973)) ([4ff4939](4ff4939))
* ux improvements to publish modal ([#1998](#1998)) ([ea4f632](ea4f632))

### Bug Fixes

* **ci:** parsing "ipfs-cluster-ctl peers ls" output ([#1966](#1966)) ([828e460](828e460))
* korean detection ([#2005](#2005)) ([362dab8](362dab8))
* Kubo agent text to link via ReleaseLink [#2010](#2010) ([#2011](#2011)) ([3d04988](3d04988))
* nodejs readme badges ([#1985](#1985)) ([a9e661b](a9e661b))
* remove web ui version and keep revision ([#2000](#2000)) ([42ed78d](42ed78d))
* resolve issues with automated releases  ([#1974](#1974)) ([9a7cfad](9a7cfad))

### Trivial Changes

* add missing classnames dependency ([#1977](#1977)) ([c4216b8](c4216b8))
* **deps:** update react-scripts ([#1969](#1969)) ([136b260](136b260))
* pull transifex translations ([#1996](#1996)) ([0de4267](0de4267))
* Pull transifex translations ([#2003](#2003)) ([cc51b15](cc51b15))
* **readme:** NodeJS version support info ([#1986](#1986)) ([829450d](829450d))
* **readme:** update release steps ([#1963](#1963)) ([c5b4822](c5b4822))
* Update .github/workflows/stale.yml [skip ci] ([f15818d](f15818d))
* update storybook and stories ([#2007](#2007)) ([83ceac1](83ceac1)), closes [/github.com/storybookjs/storybook/blob/next/MIGRATION.md#webpack-5](https://github.com/ipfs//github.com/storybookjs/storybook/blob/next/MIGRATION.md/issues/webpack-5)
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 2.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Improve UX of IPNS publishing
4 participants