Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace distribution chart with better node stats #902

Merged
merged 6 commits into from Dec 13, 2018

Conversation

olizilla
Copy link
Member

@olizilla olizilla commented Dec 10, 2018

wip on #887 to dial down geolocation activity

webui-connection-status

screenshot 2018-12-10 at 22 50 27

screenshot 2018-12-11 at 09 01 38

License: MIT
Signed-off-by: Oli Evans oli@tableflip.io

wip on #887 to dial down geolocation activity

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@ghost ghost assigned olizilla Dec 10, 2018
@ghost ghost added the status/in-progress In progress label Dec 10, 2018
@olizilla
Copy link
Member Author

@lidel this PR comes from

  1. A need to only do gelocation look-ups on the peers page, which means we can't have the distribution chart on the status page, as we'd have no data for it.
  2. Usability testing, that showed it wasn't explicit from the status page that you were connected to IPFS, the need for some context for new users, hence the "connected to IPFS, Sharing nMB, discovered x peers.
  3. Refactoring the status widgets into smaller pieces so I can move them around and experiement.

The code needs tidying up, and i18n, but It'd help to get a quick thumbs up from y'all (@lidel @fsdiogo @hacdias) or any questions concerns you might have.

Of note, this doesn't give us the full repo size widget that @lidel came up with in #887 (comment) but that will need some design effort, so we can tackle it as a seperate PR.

- Adds a Shell component to show terminal info
- Adds a Definition component to show key/value info lists
- Show help to user when connection to the api is lost

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@olizilla
Copy link
Member Author

Some cool things I'd like to draw attention too

https://github.com/ipfs-shipyard/ipfs-webui/blob/92823a451679e72fbf4822c92b0d65a6f567014b/src/status/NodeInfo.js#L29-L32

  • A Details component to for collapsable content that just serves to make sure the details element polyfill is included for Edge
  • A super fun, Shell component for when you really want to show a terminal output example.

https://github.com/ipfs-shipyard/ipfs-webui/blob/92823a451679e72fbf4822c92b0d65a6f567014b/src/status/StatusNotConnected.js#L16-L20

- State clearly that the user is connected to IPFS
- Show repo size as a link to the files page
- Show peers discovered as a link to the peers page
- Show clearly when connection is lost and steps to fix it.
- Refactor status page and extract out reusable components

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@olizilla olizilla changed the title wip: remove distribution chart from status page replace distribution chart with better node stats Dec 12, 2018
@olizilla
Copy link
Member Author

This is ready for review now. Figuring out ICU i18n keys is hard.

License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
src/components/definition/Definition.js Outdated Show resolved Hide resolved
src/status/NodeInfoAdvanced.js Outdated Show resolved Hide resolved
src/status/NetworkTraffic.js Outdated Show resolved Hide resolved
src/status/NetworkTraffic.js Outdated Show resolved Hide resolved
src/status/StatusPage.js Show resolved Hide resolved
fsdiogo and others added 2 commits December 13, 2018 12:55
Co-Authored-By: olizilla <oli@tableflip.io>
License: MIT
Signed-off-by: Oli Evans <oli@tableflip.io>
@olizilla olizilla merged commit 895420e into master Dec 13, 2018
@olizilla olizilla deleted the remove-distribution-chart-from-status-page branch December 13, 2018 15:04
@ghost ghost removed the status/in-progress In progress label Dec 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants