Upgrade dependencies and some cleanup #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dignifiedquire
force-pushed
the
upgrade-deps
branch
from
c4736d4
to
e077210
Compare
dignifiedquire
changed the title
| var current = multiaddrs[0].split('/') | ||
| var address = current[2] | ||
| // No support for ip6 lookups currently | ||
| if (isLocal(address) || current[1] === 'ip6') return getLocation(ipfs, multiaddrs.slice(1), cb) |
There was a problem hiding this comment.
Can we always do curly ifs? Actually, my standard with vim's syntastic always warns me of not doing curly ifs, doesn't it happen for you?
There was a problem hiding this comment.
Nope as far as I know standard only errors on multiline ifs without curlys, which is what I adopted, no curlys if one line, curlys for multiline. Sounds like your vim plugin needs some updates ;)
But I don't have strong feelings about it, I just don't like curlys if I can avoid them ;)
There was a problem hiding this comment.
sounds good, going to merge then :)
|
LGTM :) Thank you, @dignifiedquire ! :) |
daviddias
added a commit
that referenced
this pull request
Nov 8, 2015
Upgrade dependencies and some cleanup
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
static/fontsin favor ofnode_modules/font-awesome(Resolves Pulls correct font-awesome fonts into the static directory #72)