-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade dependencies and some cleanup #92
Conversation
c4736d4
to
e077210
Compare
var current = multiaddrs[0].split('/') | ||
var address = current[2] | ||
// No support for ip6 lookups currently | ||
if (isLocal(address) || current[1] === 'ip6') return getLocation(ipfs, multiaddrs.slice(1), cb) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we always do curly ifs? Actually, my standard with vim's syntastic always warns me of not doing curly ifs, doesn't it happen for you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope as far as I know standard only errors on multiline ifs without curlys, which is what I adopted, no curlys if one line, curlys for multiline. Sounds like your vim plugin needs some updates ;)
But I don't have strong feelings about it, I just don't like curlys if I can avoid them ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good, going to merge then :)
LGTM :) Thank you, @dignifiedquire ! :) |
Upgrade dependencies and some cleanup
static/fonts
in favor ofnode_modules/font-awesome
(Resolves Pulls correct font-awesome fonts into the static directory #72)