Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SHA1 as weakest link? #35

Closed
kpcyrd opened this issue Sep 18, 2014 · 3 comments
Closed

SHA1 as weakest link? #35

kpcyrd opened this issue Sep 18, 2014 · 3 comments

Comments

@kpcyrd
Copy link

kpcyrd commented Sep 18, 2014

I'm not sure if you're using git itself or just the idea. If you aren't actually using git, please ignore the next part :)

git uses sha1 for checking integrity. There are known flaws in SHA1. Isn't that an issue for your filesystem? Have you considered using a modified version of git?

@mappum
Copy link

mappum commented Sep 18, 2014

We aren't actually using Git, and the hash algorithm currently being used is SHA256. Thanks for the concern, though. :)

@jbenet
Copy link
Member

jbenet commented Sep 18, 2014

See also: jbenet/multihash

And check the paper for descriptions on hashes and formats.

:)

Sent from Mailbox

On Thu, Sep 18, 2014 at 2:22 PM, Matt Bell notifications@github.com
wrote:

We aren't actually using Git, and the hash algorithm currently being used is SHA256. Thanks for the concern, though. :)

Reply to this email directly or view it on GitHub:
#35 (comment)

@kpcyrd
Copy link
Author

kpcyrd commented Sep 18, 2014

Sounds great, thanks :) I'm closing this issue.

@kpcyrd kpcyrd closed this as completed Sep 18, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants