Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fetch timeout has better error UX #378

Merged
merged 2 commits into from Jul 12, 2023
Merged

fix: fetch timeout has better error UX #378

merged 2 commits into from Jul 12, 2023

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Jul 12, 2023 •
edited

PR to address issue pointed out in explore.ipld.io PR comment: ipld/explore.ipld.io#119 (review)

image

@SgtPooki SgtPooki requested a review from a team as a code owner July 12, 2023 02:14
@SgtPooki SgtPooki mentioned this pull request Jul 12, 2023
Merged
2 tasks
SgtPooki
SgtPooki commented Jul 12, 2023
View reviewed changes
Copy link
Member Author

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self review

src/lib/errors.ts Outdated Show resolved Hide resolved
@SgtPooki
Copy link
Member Author

SgtPooki commented Jul 12, 2023 •
edited

Note: if an error does not extend IpldExploreError, it's regular toString() result is output in the error message.

I commented out the BlockFetchTimeoutError just to test this:

image

@SgtPooki SgtPooki merged commit 008f83d into master Jul 12, 2023
4 checks passed
@SgtPooki SgtPooki deleted the fix/fetch-error-msg branch July 12, 2023 16:42
@lidel
Copy link
Member

lidel commented Jul 13, 2023

Awesome! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SgtPooki @lidel