Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dag-jose decoder #380

Merged
merged 2 commits into from Aug 31, 2023
Merged

Enable dag-jose decoder #380

merged 2 commits into from Aug 31, 2023

Conversation

m0ar
Copy link
Contributor

@m0ar m0ar commented Jul 14, 2023

This PR adds support for using the dag-jose codec, useful viewing and traversing Ceramic Streams ⛓️

Will solve this issue in ipfs-webui: ipfs/ipfs-webui#1912

image

@m0ar m0ar requested a review from a team as a code owner July 14, 2023 09:33
@welcome
Copy link

welcome bot commented Jul 14, 2023

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@SgtPooki
Copy link
Member

Do you have an example CID we can use to test this out?

Copy link
Member

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but i’d love to get a CID to test to confirm

@SgtPooki
Copy link
Member

Let's also add tests to confirm things continue working properly

@m0ar
Copy link
Contributor Author

m0ar commented Aug 14, 2023

@SgtPooki Sorry for the late response, been on vacation 🌴

Here is a public CID that I pulled from a cerscan stream you can try it out with: bagcqcerazgxx3olkiyn3z7osiwx7645un5t7tq3qg66okcv5it2ptlvf2izq

image

@m0ar
Copy link
Contributor Author

m0ar commented Aug 14, 2023

Let's also add tests to confirm things continue working properly

@SgtPooki I cannot find any existing tests in this package, so I'm not sure how I would go about doing that.

@SgtPooki
Copy link
Member

@SgtPooki I cannot find any existing tests in this package, so I'm not sure how I would go about doing that.

@m0ar you know what, you're right.. I believe the tests are in explore.ipld.io and webui :( I would really love to merge explore.ipld.io and this lib into one..

@SgtPooki SgtPooki merged commit 612d2b0 into ipfs:master Aug 31, 2023
16 checks passed
@m0ar
Copy link
Contributor Author

m0ar commented Sep 5, 2023

@SgtPooki Thanks for the merge! Could you create a new release so I can PR an update to solve ipfs/ipfs-webui#1912?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants