Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename to dag-service #381

Merged
merged 3 commits into from
Aug 12, 2020
Merged

Rename to dag-service #381

merged 3 commits into from
Aug 12, 2020

Conversation

Gozala
Copy link
Collaborator

@Gozala Gozala commented Aug 11, 2020

Description

Renames the project to js-dag-service

Fixes #336

LICENSE Outdated

Copyright (c) 2020 Protocol Labs
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this cool ? Do we need to do extra steps ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, since there are multiple contributors involved here, we might need to have this as something more like:

Copyright (c) 2020 Project contributors

But I'm not all that well-versed in the potential issues here. Maybe @andrewxhill has some thoughts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nothing from me, no pref

README.md Show resolved Hide resolved
Copy link
Collaborator

@carsonfarmer carsonfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left one or two comments, and would like some feedback from others re: copy-write as I'm less familiar with these types of things.

LICENSE Outdated

Copyright (c) 2020 Protocol Labs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm, since there are multiple contributors involved here, we might need to have this as something more like:

Copyright (c) 2020 Project contributors

But I'm not all that well-versed in the potential issues here. Maybe @andrewxhill has some thoughts?

README.md Outdated Show resolved Hide resolved
Co-authored-by: Carson Farmer <carson.farmer@gmail.com>
@mikeal
Copy link

mikeal commented Aug 11, 2020

Should be dual Apache2 & MIT https://protocol.ai/blog/announcing-the-permissive-license-stack/

@Gozala Gozala mentioned this pull request Aug 12, 2020
3 tasks
@Gozala
Copy link
Collaborator Author

Gozala commented Aug 12, 2020

Should be dual Apache2 & MIT https://protocol.ai/blog/announcing-the-permissive-license-stack/

Update pull request to change to dual license and created an issue to request signoffs to do so #382

Copy link
Collaborator

@carsonfarmer carsonfarmer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks like there are no further changes/discussion required. Let's do it.

@Gozala Gozala merged commit cdb99b5 into ipfs:master Aug 12, 2020
@Gozala Gozala deleted the rename branch August 12, 2020 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lets rename this project to a thing that better represents what it is
4 participants