This repository has been archived by the owner on Mar 23, 2023. It is now read-only.
Optimize prefix search #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
vweevers
reviewed
Dec 14, 2019
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
Signed-off-by: Carson Farmer <carson.farmer@gmail.com>
|
Nice spot, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves prefix search slightly by taking advantage of level's built-in query parameters. In particular, it uses
gteandltkeys, and lets the db do the prefix searching rather than using a filter. In my (albeit rough) tests, this can lead to pretty significant speedups in cases with many entries with varying key prefixes. The 'trick' is to setgteto prefix andltto prefix plus the '\xFF' hex escape sequence. Passes tests and does not change the API (though actually I did sneak in atoString()call to supportKey-based prefixes). If this is something worth officially supporting, I could also update the docs.