feat(decision-engine): split large block messages #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
victorb
suggested changes
Feb 20, 2017
|
@victorbjelkholm updated |
| @@ -35,14 +38,42 @@ class DecisionEngine { | |||
| } | |||
|
|
|||
| _sendBlocks (env, cb) { | |||
| // split into messges of max 512 * 1024 bytes | |||
There was a problem hiding this comment.
Ah yes, because of https://github.com/ipfs/go-ipfs/blob/master/exchange/bitswap/network/ipfs_impl.go#L186
We have a limit to the maximum message size you can send.
There was a problem hiding this comment.
Yes, though that is higher than the multiplex limit you implemented in go. So I'm not sure if you could run into the same issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.