Prevent double callback in getBlocks. #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -190,6 +190,7 @@ module.exports = class Bitwap { | |||
| }) | |||
| } | |||
|
|
|||
| var finished = false | |||
|
Thanks for the catch, one small nit other than that looks good |
|
done
|
|
Thanks, lgtm could you please squash the commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this after doing some digging in ipfs/js-ipfs#318.
It looks like we can call
finishboth here and here.As far as I've been able to tell, a getBlock request will reach datastore.get and block there because the
putis still in progress. At this point the notification handler here will be set up. Once the block finishes beingput, it both a) fires the notification, and also b) makes that earlierdatastore.getreturn successfully, makingfinishget called twice.I'm not very familiar with this module, so let me know if there's a more complete fix here than simply preventing the cb from running twice! ❤️