Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move process to dev dependencies #342

Merged
merged 1 commit into from
Jun 15, 2021

Conversation

bgins
Copy link
Contributor

@bgins bgins commented May 26, 2021

Hello 👋. We recently noticed that some modern bundlers moving away from shimming node built-ins (vitejs/vite#2723 (comment)), and that process is included as a dependency here.

This PR would move process from dependencies to devDependencies. It appears to only be used in tests and benchmarks, and everything builds and tests pass afterwards.

I think this change would be alright, but certainly feel free to decline or request changes if I have overlooked something! 🙏

@welcome
Copy link

welcome bot commented May 26, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@lidel lidel added this to In Review in Maintenance Priorities - JS via automation May 31, 2021
@lidel lidel requested a review from achingbrain June 7, 2021 14:19
@lidel
Copy link
Member

lidel commented Jun 7, 2021

@achingbrain sounds like you are the most familiar with this area of js-ipfs?

@jorishermans
Copy link

jorishermans commented Jun 9, 2021

What is the process of this issue?

Important for usage in vitejs ;)

@BigLep BigLep requested a review from Gozala June 14, 2021 14:31
@BigLep
Copy link

BigLep commented Jun 14, 2021

@Gozala : We're hoping during your tribute week you can review and merge.

Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks!

@achingbrain achingbrain merged commit 0e300d6 into ipfs:master Jun 15, 2021
Maintenance Priorities - JS automation moved this from In Review to Done Jun 15, 2021
@bgins bgins deleted the feat/move-process-dependency branch June 15, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants