network #4
network #4
Conversation
| // connected. Once we have Peer Routing, we will be able | ||
| // to find the Peer | ||
| if (this.libp2p.swarm.muxedConns[peerId.toB58String()]) { | ||
| // TODO: ask - want _onPeerConnected to be called here too? |
There was a problem hiding this comment.
@dignifiedquire should I call _onPeerConnected here too? Or is the cb enough to signal we successfully dialed (I'm afraid that we fire to routines for connecting to the same peer)
There was a problem hiding this comment.
No need to call _onPeerConnected here, as that will already have been called from the first connection in this case.
|
@diasdavid can you rebase please? |
|
@dignifiedquire rebased, but do not merge yet :) |
daviddias
force-pushed
the
network
branch
3 times, most recently
from
d08ced8
to
bc00898
Compare
|
@dignifiedquire the network is implemented :) |
| it('block is retrived from peer', (done) => { | ||
| // Not sure if I understand what is going on here | ||
| // test fails because now the network is not properly mocked | ||
| // what are these net.stores and mockNet.bitswaps? |
There was a problem hiding this comment.
@dignifiedquire could you clarify what is going on in this test? libp2p needs to be properly mocked, but I couldn't get what was exactly was going on/intended.
There was a problem hiding this comment.
Yes, I need to change the mock network tool to now mock libp2p instead of the network instance
fix(network): better message handling
This is a WIP, missing:
peer-mux-*eventssendMessagecall_receiveMessage