feat: cid agnostic blockstore .get and .has #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
ghost
assigned License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
49 tasks
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
changed the title
alanshaw
changed the title
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
jacobheun
approved these changes
Dec 7, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the blockstore to check for a CID of the other version (if applicable) when getting data or checking for existence.
If content is found for the other version of a CID then we
putthat block in the store under the passed CID. This causes some duplication.When we migrate to using multihash as key instead of CID these duplicates will be purged.
FYI this is the same strategy that go-ipfs uses currently: ipfs/kubo#5285
depends on multiformats/js-cid#71Allows us to pass these interop tests: