feat: support unixfs metadata and formatting it #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 21, 2019
alanshaw
requested changes
Dec 2, 2019
src/files/glob-source.js
Outdated
| realpath: false, | ||
| absolute: true | ||
| }) | ||
|
|
||
| for await (const p of glob(path, '**/*', globOptions)) { | ||
| if (preserveMode || preserveMtime) { | ||
| const stat = await fs.stat(p) |
There was a problem hiding this comment.
In the future we might get some perf wins by parallel mapping these.
There was a problem hiding this comment.
Possibly - our bottlenecks typically aren't from reading paths from the filesystem but it's worth measuring before jumping to conclusions. Like I just did. 
2 tasks
|
@hugomrdias if you're happy with this PR could you merge & release it please? |
|
can you fix the conflicts 🙏 |
|
@hugomrdias done. |
hugomrdias
approved these changes
Dec 6, 2019
|
@hugomrdias this went out in the same release as #15 so now UnixFSv1.5 metadata is dependent on the removal of node streams & pull-streams from IPFS, which it shouldn't be. Can this PR either be backported to |
hugomrdias
added a commit
that referenced
this pull request
Dec 11, 2019
Adds mode and mtime properties to normalised .add inputs, also adds functions for turning metadata into strings for CLI use. BREAKING CHANGE: In order to support metadata on intermediate directories, globSource in this module will now emit directories and files where previously it only emitted files.
hugomrdias
added a commit
that referenced
this pull request
Dec 11, 2019
Adds mode and mtime properties to normalised .add inputs, also adds functions for turning metadata into strings for CLI use. BREAKING CHANGE: In order to support metadata on intermediate directories, globSource in this module will now emit directories and files where previously it only emitted files.
achingbrain
added a commit
that referenced
this pull request
Dec 11, 2019
Adds mode and mtime properties to normalised .add inputs, also adds functions for turning metadata into strings for CLI use. BREAKING CHANGE: In order to support metadata on intermediate directories, globSource in this module will now emit directories and files where previously it only emitted files.
hugomrdias
pushed a commit
that referenced
this pull request
Dec 11, 2019
Adds mode and mtime properties to normalised .add inputs, also adds functions for turning metadata into strings for CLI use. BREAKING CHANGE: In order to support metadata on intermediate directories, globSource in this module will now emit directories and files where previously it only emitted files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
modeandmtimeproperties to normalised.addinputs, also adds functions for turning metadata into strings for CLI use.BREAKING CHANGE:
In order to support metadata on intermediate directories,
globSourcein this module will now emit directories and files where previously it only emitted files.