Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use node-fetch fork with fix for stream closed prematurely bug #127

Merged
merged 3 commits into from
May 28, 2021

Conversation

achingbrain
Copy link
Member

node-fetch/node-fetch#1064 fixes a bug in node-fetch to make it handle situations where the stream closes prematurely but it's been merged into the v3 release tree which is still future tech with no release date.

node-fetch/node-fetch#1172 backports that fix to v2 but although approved it's not been merged and released yet so here we use a temporary fork published with that PR merged in.

node-fetch/node-fetch#1064 fixes a bug in node-fetch
to make it handle situations where the stream closes prematurely but
it's been merged into the v3 release tree which is still future tech
with no release date.

node-fetch/node-fetch#1172 backports that fix
to v2 but although approved it's not been merged and released yet
so here we use a temporary fork published with that PR merged in.
@achingbrain
Copy link
Member Author

Will need backporting to v7 and v6 of this module to cover ipfs@0.55.x and ipfs@0.54.x

@achingbrain
Copy link
Member Author

Rolled up to ipfs in ipfs/js-ipfs#3468

@achingbrain achingbrain merged commit 4ad105a into master May 28, 2021
@achingbrain achingbrain deleted the fix/use-node-fetch-fork-with-stream-closed-fix branch May 28, 2021 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant