Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Switch CIDv1 from Base58 to Base32 (js-ipfs) #1995
Right now if someone wants to use CIDv1 they can opt-in via
$ jsipfs add --cid-version 1 guardian.jpg added zb2rhk6GMPQF3hfzwXTaNYFLKomMeC6UXdUt6jZKPpeVirLtV guardian.jpg
To get the representation we aim for, they need to convert Base58 CIDv1 to Base32 in additional step:
$ jsipfs cid base32 zb2rhk6GMPQF3hfzwXTaNYFLKomMeC6UXdUt6jZKPpeVirLtV bafkreigh2akiscaildcqabsyg3dfr6chu3fgpregiymsck7e7aqa4s52zy
OR pass additional
$ jsipfs add --cid-version 1 --cid-base base32 guardian.jpg added bafkreigh2akiscaildcqabsyg3dfr6chu3fgpregiymsck7e7aqa4s52zy guardian.jpg
The need for the conversion step is not only unnecessary, but harmful to our migration efforts. Users report confusion why CIDv1 produced by js-ipfs can't be used in
It is really embarrassing when we need to ask people to use
We should switch default representation of CIDv1 from Base58 to Base32 (without making CIDv1 the default itself).
This will ensure that:
referenced this issue
Apr 15, 2019
@alanshaw I'd like to keep this open until
Rationale: switching to CIDv1 as the new default will require rewriting a lot of tests, across many packages.
I wonder what would be the fastest way to do this.