Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: support legacy links in cbor data #2631

Merged
merged 4 commits into from
Nov 27, 2019
Merged

fix: support legacy links in cbor data #2631

merged 4 commits into from
Nov 27, 2019

Conversation

alanshaw
Copy link
Member

@alanshaw alanshaw commented Nov 25, 2019 •
edited
Loading

@alanshaw
chore: remove .only
1187ad9
@alanshaw
fix: stupid mistake
6592f98 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw
chore: update dag-cbor-links dep
e0e39c9
achingbrain
achingbrain approved these changes Nov 27, 2019
View reviewed changes
Copy link
Member

@achingbrain achingbrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe add a test for the error that occurs when passing a JSON object with a single / property, the value of which isn't a valid CID?

@alanshaw alanshaw merged commit f98023b into master Nov 27, 2019
@alanshaw alanshaw deleted the fix/dag-put-cbor branch November 27, 2019 11:00
alanshaw added a commit that referenced this pull request Nov 28, 2019
@alanshaw
fix: support legacy links in cbor data (#2631)
3f446d6 
License: MIT
Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
@alanshaw alanshaw mentioned this pull request Nov 28, 2019
Closed
52 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@achingbrain achingbrain achingbrain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alanshaw @achingbrain