This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: cancellable api calls #2993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achingbrain
force-pushed
the
feat/cancellable-requests
branch
8 times, most recently
from
ee5d065
to
f64b846
Compare
Passes a [AbortSignal](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal) to every API call which emits a `abort` event when the caller is no longer interested in the result of the operation. Lower level code that creates resources or has other long-term effects should tear down those resources early if the `abort` event is received. Adds support for `timeout` options to every API call that will emit an `abort` event on the passed signal and throw a Timeout error. Finally `abort` events are triggered if the current request arrived via the HTTP API and the request was aborted from the client - that is, a `disconnect` event is fired by Hapi. - Updates the core-api docs to add these new options. - Refactors HTTP API to replace custom args parsing with Joi - Tests all HTTP API endpoints - Adds pin support to `ipfs.block.put`- fixes #3015
achingbrain
force-pushed
the
feat/cancellable-requests
branch
from
f64b846
to
5e37e27
Compare
hugomrdias
suggested changes
May 5, 2020
hugomrdias
suggested changes
May 5, 2020
hugomrdias
approved these changes
May 6, 2020
achingbrain
force-pushed
the
feat/cancellable-requests
branch
from
0e9c145
to
0cbbf5d
Compare
SgtPooki
referenced
this pull request
in ipfs/js-kubo-rpc-client
Aug 18, 2022
Passes a [AbortSignal](https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal) to every API call which emits a `abort` event when the caller is no longer interested in the result of the operation. Lower level code that creates resources or has other long-term effects should tear down those resources early if the `abort` event is received. Adds support for `timeout` options to every API call that will emit an `abort` event on the passed signal and throw a Timeout error. Finally `abort` events are triggered if the current request arrived via the HTTP API and the request was aborted from the client - that is, a `disconnect` event is fired by Hapi. - Updates the core-api docs to add these new options. - Refactors HTTP API to replace custom args parsing with Joi - Tests all HTTP API endpoints - Adds pin support to `ipfs.block.put`- fixes #3015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passes a AbortSignal to every API call which emits a
abortevent when the caller is no longer interested in the result of the operation.Lower level code that creates resources or has other long-term effects should tear down those resources early if the
abortevent is received.Adds support for
timeoutoptions to every API call that will emit anabortevent on the passed signal and throw a Timeout error.Finally
abortevents are triggered if the current request arrived via the HTTP API and the request was aborted from the client - that is, adisconnectevent is fired by Hapi.Updates the core-api docs to add these new options.