This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix(pubsub.peers): remove the requirement for a topic #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@diasdavid LGTM. The failed travis CI has nothing to do with this PR |
daviddias
suggested changes
Dec 5, 2017
src/core/components/pubsub.js
Outdated
| @@ -77,9 +77,18 @@ module.exports = function pubsub (self) { | |||
| return setImmediate(() => callback(new Error(OFFLINE_ERROR))) | |||
| } | |||
|
|
|||
| const peers = Array.from(self._pubsub.peers.values()) | |||
| .filter((peer) => peer.topics.has(topic)) | |||
There was a problem hiding this comment.
The change required here could just be:
.filter((peer) => topic ? peer.topics.has(topic)) : true
There was a problem hiding this comment.
@haoliangyu mind updating to the above solution?
|
@diasdavid The change has been made. |
RangerMauve
reviewed
Dec 5, 2017
| const peers = Array.from(self._pubsub.peers.values()) | ||
| .filter((peer) => peer.topics.has(topic)) | ||
| .filter((peer) => topic ? peer.topics.has(topic) : true) |
There was a problem hiding this comment.
Why bother doing the filter if you're getting all peers anyway?
daviddias
approved these changes
Dec 5, 2017
This was referenced Mar 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1100