This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
test: use pin tests #1405
Merged
test: use pin tests #1405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
daviddias
commented
Jun 20, 2018
|
|
||
| require('./pin') | ||
| require('./pin-set') | ||
| // require('./key-exchange') |
There was a problem hiding this comment.
Does anyone know why these tests were never being run? @richardschneider ??
There was a problem hiding this comment.
@diasdavid No idea, the tests should be run.
There was a problem hiding this comment.
They weren't being picked up anywhere. I'll add them as a separate PR then.
Merged
License: MIT Signed-off-by: Alan Shaw <alan@tableflip.io>
alanshaw
approved these changes
Jun 22, 2018
|
Thank you @alanshaw ❤️ |
This was referenced Jan 17, 2022
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
This was referenced Jan 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.