Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: XMLHttpRequest is deprecated and unavailable in service workers #1478

Merged
merged 1 commit into from
Jul 29, 2018

Conversation

alanshaw
Copy link
Member

This PR switches to using the fetch API instead.

fixes #1477

This PR switches to using the fetch API instead.

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
@ghost ghost assigned alanshaw Jul 29, 2018
@ghost ghost added the status/in-progress In progress label Jul 29, 2018
@alanshaw alanshaw changed the title fix: XMLHTTPRequest is deprecated and unavailable in service workers fix: XMLHttpRequest is deprecated and unavailable in service workers Jul 29, 2018
Copy link
Member

@hugomrdias hugomrdias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

Tested and everything is working fine 👍
Thanks @alanshaw

@alanshaw alanshaw merged commit 7d6f0ca into master Jul 29, 2018
@ghost ghost removed the status/in-progress In progress label Jul 29, 2018
@alanshaw alanshaw deleted the fix/preload-in-service-worker branch July 29, 2018 22:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

XMLHttpRequest cannot be used when running ipfs in a service worker
3 participants