This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: swallowed errors #1860
Merged
fix: swallowed errors #1860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
This was referenced Feb 3, 2019
The switch to using `yargs-promise` for `ipfs init` and `ipfs daemon` commands caused an unhandled promise rejection and in some cases would cause an error to not be printed to the console. This PR greatly simplifies the code in `src/cli/bin.js`, to always use `yargs-promise`. Command handlers are now passed an async `getIpfs` function instead of an `ipfs` instance. It means that we don't have to differentiate between commands that use an IPFS instance in `src/cli/bin.js`, giving the handler the power to call `getIpfs` or not to obtain an IPFS instance as and when needed. This removes a whole bunch of complexity from `src/cli/bin.js` at the cost of adding a single line to every command handler that needs to use an IPFS instance. This enables operations like `echo "hello" | jsipfs add -q | jsipfs cid base32` to work without `jsipfs cid base32` failing because it's trying to acquire a repo lock when it doesn't use IPFS at all. fixes #1835 refs #1858 refs libp2p/js-libp2p#311 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
force-pushed
the
fix/swallowed-errors
branch
from
ea339df
to
540a77d
Compare
This was referenced Jul 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch to using
yargs-promiseforipfs initandipfs daemoncommands caused an unhandled promise rejection and in some cases would cause an error to not be printed to the console.This PR greatly simplifies the code in
src/cli/bin.js, to always useyargs-promise. Command handlers are now passed an asyncgetIpfsfunction instead of anipfsinstance. It means that we don't have to differentiate between commands that use an IPFS instance insrc/cli/bin.js, giving the handler the power to callgetIpfsor not to obtain an IPFS instance as and when needed. This removes a whole bunch of complexity fromsrc/cli/bin.jsat the cost of adding a single line to every command handler that needs to use an IPFS instance.This enables operations like
echo "hello" | jsipfs add -q | jsipfs cid base32to work withoutjsipfs cid base32failing because it's trying to acquire a repo lock when it doesn't use IPFS at all.fixes #1835
refs #1858
refs libp2p/js-libp2p#311