Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: use libp2p auto dial #1983

Merged
merged 6 commits into from Apr 11, 2019
Merged

fix: use libp2p auto dial #1983

merged 6 commits into from Apr 11, 2019

Conversation

jacobheun
Copy link
Contributor

@jacobheun jacobheun commented Apr 10, 2019

Moves all peer discovery dialing logic to libp2p, which prevents dialing discovered nodes when we have enough peers.

@ghost ghost assigned jacobheun Apr 10, 2019
@ghost ghost added the status/in-progress In progress label Apr 10, 2019
Copy link
Member

@alanshaw alanshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, can the autoDial config please be added to the README?

FYI, I'm hoping that flakey windows test failure will be fixed by #1985

@jacobheun
Copy link
Contributor Author

Added it to the libp2p config section of the readme.

@jacobheun
Copy link
Contributor Author

I've also updated the custom libp2p example and preemptively added the dependency as 0.25.0 for libp2p. I've gone through all the libp2p examples to update those, libp2p/js-libp2p#353.

I'll do some final testing this afternoon and do a release of 0.25 tonight or first thing tomorrow morning.

cc @vasco-santos

@alanshaw alanshaw mentioned this pull request Apr 11, 2019
1 task
@alanshaw alanshaw marked this pull request as ready for review April 11, 2019 14:56
@alanshaw alanshaw changed the title [WIP] fix: use libp2p auto dial fix: use libp2p auto dial Apr 11, 2019
@alanshaw alanshaw merged commit 7f1fb26 into master Apr 11, 2019
@alanshaw alanshaw deleted the fix/libp2p-autodial branch April 11, 2019 14:57
@ghost ghost removed the status/in-progress In progress label Apr 11, 2019
@momack2 momack2 added this to Done in ipfs/js-ipfs May 10, 2019
@momack2 momack2 added this to Done in ipfs/js-waffle May 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants