Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

chore: use ipfs npm registry in travis #3061

Closed
wants to merge 1 commit into from

Conversation

tarunbatra
Copy link
Contributor

Have added a step to set npm registry in the travis build process to solve #2997.

Another way to do this would have been maintaining a .npmrc file in the root directory, but that would have lead to installs happening during development also to use ipfs npm registry which I feel is more than the scope defined.

@welcome
Copy link

welcome bot commented Jun 2, 2020

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@achingbrain
Copy link
Member

Thanks for submitting this, I will merge it but not immediately as the service behind registry.js.ipfs.io needs updating to be more stable. The work is about 80% done, I just need to find the time to finish it off.

@achingbrain achingbrain linked an issue Jun 4, 2020 that may be closed by this pull request
@tinytb
Copy link

tinytb commented Feb 3, 2023

What is the service behind registry.js.ipfs.io? How (un)stable is it?

@achingbrain
Copy link
Member

achingbrain commented Jun 2, 2023

Thank you so much for opening this PR and for your patience in getting it merged. js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide.

The registry.js.ipfs.io service was retired so this isn't going to get done. It (still) really needs a bit of an overhaul tbh.

@achingbrain achingbrain closed this Jun 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Update .travis to install from registry.js.ipfs.io
4 participants