Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: transfer set #3573

Merged
merged 17 commits into from
Sep 30, 2021
Merged

fix: transfer set #3573

merged 17 commits into from
Sep 30, 2021

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Feb 26, 2021

This pull requests supersedes #3481 that passes transferables as sets instead of arrays (in order to avoid duplicates in them). However #3481 still kept using arrays during encoding and only afterwards it turned it into a set to eliminate duplicates.

This change instead updates type of transfer to set to eliminate intermediary arrays in favor of sets.

Fixes #3402

@Gozala
Copy link
Contributor Author

Gozala commented Feb 27, 2021

Example seems to be failing because, webpack-cli get hoisted and instead of using local webpack@5 it uses hoisted webpack@4 and fails 😭

I'll try to figure out how to resolve this and push a fix, that said I think it's ready to be reviewed.

@Gozala
Copy link
Contributor Author

Gozala commented Mar 2, 2021

I've spend couple of hours today trying to get the last test passing, but I could not work out the hoisting problem. I also tried to just update all webpack deps to webpack@5 but that broke aegir build which started to getting webpack@5 instead webpack@4 it expects.

@BigLep BigLep added the status/in-progress In progress label Mar 15, 2021
@lidel lidel added this to In Review in Maintenance Priorities - Go via automation Apr 19, 2021
@lidel
Copy link
Member

lidel commented Apr 26, 2021

@Gozala is this waiting for TS work to land first, or is it blocked on something else?

Does this PR close #3402? (if so, can you add the "Clsoes #.." to the description?)

@Gozala
Copy link
Contributor Author

Gozala commented Apr 26, 2021

@Gozala is this waiting for TS work to land first, or is it blocked on something else?

This PR just needs to be updated to merge all the changes in the tree. However due to bunch of issues with duplicate deps in the tree (caused by TS Work) it's best to wait for that to settle instead of duplicating effort.

@BigLep BigLep removed this from In Review in Maintenance Priorities - Go May 10, 2021
@BigLep BigLep added this to In Review in Maintenance Priorities - JS via automation May 10, 2021
@lidel lidel moved this from In Review to In Progress in Maintenance Priorities - JS May 17, 2021
@lidel lidel added status/deferred Conscious decision to pause or backlog and removed status/in-progress In progress labels May 24, 2021
@BigLep BigLep moved this from In Progress to Weekly Candidates in Maintenance Priorities - JS May 24, 2021
@lidel lidel added status/inactive No significant work in the previous month and removed status/deferred Conscious decision to pause or backlog labels May 24, 2021
@lidel lidel added the P3 Low: Not priority right now label Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 Low: Not priority right now status/in-progress In progress
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ipfs-message-port-* should ensure no transferables are duplicated
6 participants