This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
test: refactor for test sanity #733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorb
reviewed
Jan 28, 2017
| @@ -10,7 +10,7 @@ | |||
| "libp2p-ipfs-nodejs": "libp2p-ipfs-browser", | |||
| "./src/core/default-repo.js": "./src/core/default-repo-browser.js", | |||
| "./src/core/components/init-assets.js": false, | |||
| "./test/utils/temp-repo.js": "./test/utils/temp-repo-browser.js", | |||
| "./test/utils/create-repo-node.js": "./test/utils/create-repo-browser.js", | |||
There was a problem hiding this comment.
can't this just be create-repo rather?
There was a problem hiding this comment.
it could, I just standardize it because we always tag node and browser everywhere to distinguish the two, if distinction needs to happen
| @@ -14,7 +14,7 @@ function createTempRepo (repoPath) { | |||
|
|
|||
| repo.teardown = (done) => { | |||
| clean(repoPath) | |||
| done() | |||
| setImmediate(() => done()) | |||
There was a problem hiding this comment.
Should probably explain in a code-comment with reason
There was a problem hiding this comment.
It is just a safe guard, a best practice
victorb
approved these changes
Jan 28, 2017
This was referenced Oct 31, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.