This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Changes required for #968 feat/Gateway #989
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* clean up, remove commented out lines. * cleaning code, removing commented out blocks. * gateway initial tests.
License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com>
License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com>
…checks License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com>
License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com>
daviddias
suggested changes
Sep 5, 2017
test/gateway/index.js
Outdated
| describe('HTTP GATEWAY', () => { | ||
| const repoExample = path.join(__dirname, '../go-ipfs-repo') | ||
| describe('HTTP Gateway', () => { | ||
| const repoExample = path.join(__dirname, '../js-ipfs-repo') |
There was a problem hiding this comment.
Hi @ya7ya. It seems I didn't explain myself well. What I mean is that there should be no "repo copying" either from a previously generated go-ipfs or js-ipfs node. When you spawn a daemon after doing init, it will have its own repo created, that is what should be used for testing.
There was a problem hiding this comment.
@diasdavid oh, Ma bad, I'll fix that. Sorry.
There was a problem hiding this comment.
No, my bad for not being clear, I'm sorry. Thank you for pushing this :)
daviddias
approved these changes
Sep 5, 2017
|
Thank you @ya7ya :) |
|
@diasdavid 👍 :) Thank you for your review and comments, I appreciate it |
daviddias
pushed a commit
that referenced
this pull request
Sep 6, 2017
* feat: add gateway route to daemon * feat: adding Gateway endeavour - improve codebase * clean up, remove commented out lines. (#971) * clean up, remove commented out lines. * cleaning code, removing commented out blocks. * gateway initial tests. * clean up , working tests on node v8.4.0 License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com> * fix using js-ipfs-repo in gateway tests. License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com> * Using unix-fs to detect dirs, replacing object.get with DAG.get, CID checks License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com> * rename checkHash -> checkCID License: MIT Signed-off-by: Yahya <ya7yaz@gmail.com> * gateway tests: init a fresh repo
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this pull request
May 22, 2020
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some of the required Changes by @diasdavid to merge #968
unix-fsto detect directoriesjs-ipfs-repoinstead ofgo-ipfs-repofor testing gateway