This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
[FIXED] Essential Tests for Feat/gateway #999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daviddias
suggested changes
Sep 6, 2017
test/gateway/index.js
Outdated
| describe('## interface tests', () => { | ||
| fs.readdirSync(path.join(__dirname, '/interface')) | ||
| .forEach((file) => require('./interface/' + file)) | ||
| }) |
There was a problem hiding this comment.
@ya7ya why did you bring these tests back? These are designed for the API, not for the gateway.
|
@diasdavid Interface tests removed from gateway. Sorry about that. |
daviddias
approved these changes
Sep 6, 2017
This was referenced Jan 20, 2022
This was referenced Mar 21, 2022
This was referenced Oct 16, 2022
This was referenced Oct 16, 2022
This was referenced Oct 17, 2022
This was referenced Oct 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[FIXED] Repo history #997
Hey @diasdavid , These are the essential tests you mentioned in #968
Changes:
I wasn't Able to reproduce the error you mentioned . But the tests went fine.
side fix:
examples/traverse-ipld-graph/git.jskept throwing an error when linting, so I had to fix those in order to commit.