Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make sure exec matches the passed node type #184

Merged
merged 3 commits into from
Jan 21, 2018
Merged

make sure exec matches the passed node type #184

merged 3 commits into from
Jan 21, 2018

Conversation

dryajov
Copy link
Member

@dryajov dryajov commented Jan 18, 2018

No description provided.

@ghost ghost assigned dryajov Jan 18, 2018
@ghost ghost added the status/in-progress In progress label Jan 18, 2018
@dryajov dryajov changed the title make sure exec matches the passed type node type make sure exec matches the passed node type Jan 18, 2018
@codecov
Copy link

codecov bot commented Jan 19, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@dad6a0e). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #184   +/-   ##
=========================================
  Coverage          ?   89.36%           
=========================================
  Files             ?       11           
  Lines             ?      555           
  Branches          ?        0           
=========================================
  Hits              ?      496           
  Misses            ?       59           
  Partials          ?        0
Impacted Files Coverage Δ
src/remote-node/routes.js 89.61% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dad6a0e...454cbc0. Read the comment docs.

@dryajov
Copy link
Member Author

dryajov commented Jan 19, 2018

@diasdavid can we get this one merged, its needed for ipfs/interop#5

This was referenced Jan 19, 2018
Merged
Merged
Merged
@daviddias daviddias merged commit 89e9059 into master Jan 21, 2018
@ghost ghost removed the status/in-progress In progress label Jan 21, 2018
@daviddias daviddias deleted the fix/remote-node branch January 21, 2018 00:15
daviddias
daviddias reviewed Jan 21, 2018
View reviewed changes
package.json
@@ -93,6 +92,7 @@
"dirty-chai": "^2.0.1",
"go-ipfs-dep": "0.4.13",
"ipfs": "^0.27.5",
"ipfs-api": "^17.3.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dryajov only realized after that ipfs-api is now a devDep. Does this mean that folks have to pass ipfs-api everytime they want to spawn a node?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It continues to be a prod dep https://github.com/ipfs/js-ipfsd-ctl/blob/master/src/daemon-node.js#L5

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What was the rationale behind moving it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@dryajov dryajov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dryajov @daviddias