Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass ipfs config show errors #722

Merged
merged 4 commits into from
Oct 19, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 33 additions & 2 deletions src/ipfsd-daemon.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,26 @@ function translateError (err: Error & { stdout: string, stderr: string }) {
return err
}

interface TranslateUnknownErrorArgs {
err: Error | unknown
stdout: string
stderr: string
nameFallback?: string
messageFallback?: string
}

function translateUnknownError ({ err, stdout, stderr, nameFallback = 'Unknown Error', messageFallback = 'Unknown Error Message' }: TranslateUnknownErrorArgs) {
const error: Error = err as Error
const name = error?.name ?? nameFallback
const message = error?.message ?? messageFallback
return translateError({
name,
message,
stdout,
stderr
})
}

/**
* Controller for daemon nodes
*/
Expand Down Expand Up @@ -353,7 +373,8 @@ class Daemon implements Controller {
}

const {
stdout
stdout,
stderr
} = await execa(
this.exec,
['config', key],
Expand All @@ -363,7 +384,17 @@ class Daemon implements Controller {
.catch(translateError)

if (key === 'show') {
return JSON.parse(stdout)
try {
return JSON.parse(stdout)
} catch (err) {
throw translateUnknownError({
err,
stderr,
stdout,
nameFallback: 'JSON.parse error',
messageFallback: 'Failed to parse stdout as JSON'
})
}
}

return stdout.trim()
Expand Down