Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use /api/v0/routing instead of deprecated /api/v0/dht #215

Merged
merged 1 commit into from Feb 6, 2024
Merged

fix: use /api/v0/routing instead of deprecated /api/v0/dht #215

merged 1 commit into from Feb 6, 2024

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Feb 6, 2024

No description provided.

@hacdias hacdias requested a review from lidel February 6, 2024 10:36
@hacdias hacdias self-assigned this Feb 6, 2024
@hacdias hacdias mentioned this pull request Feb 6, 2024
Merged
@lidel lidel changed the title fix: use /api/v0/routing instead of deprecated /api/v0/dht feat: use /api/v0/routing instead of deprecated /api/v0/dht Feb 6, 2024
@lidel lidel changed the title feat: use /api/v0/routing instead of deprecated /api/v0/dht fix: use /api/v0/routing instead of deprecated /api/v0/dht Feb 6, 2024
lidel
lidel approved these changes Feb 6, 2024
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, I think there is no good way of doing this, but this one is the least harmful.

Context for drive-by reader / release notes:

  • Shipping this means we dont make any big waves, but users get a new version that keeps the programmatic JS API (ipfs.dht.*), but it is backed by modern /api/v0/routing commands (which are the same as deprecated /api/v0/dht).
  • This is to ensure apps continue to work when deprecated /api/v0/dht commands are removed (core/commands: remove 'ipfs dht' commands, except 'query' kubo#10328)

In the future, we will update kubo-rpc-client programmatic API, but this should do for now.

@lidel lidel merged commit 7725de3 into master Feb 6, 2024
18 checks passed
@lidel lidel deleted the use-routing branch February 6, 2024 21:58
github-actions bot pushed a commit that referenced this pull request Feb 6, 2024
@semantic-release-bot
chore(release): 3.0.3 [skip ci]
f79e670 
## [3.0.3](v3.0.2...v3.0.3) (2024-02-06)

### Bug Fixes

* use /api/v0/routing instead of deprecated /api/v0/dht ([#215](#215)) ([7725de3](7725de3))

### Trivial Changes

* Update .github/workflows/stale.yml [skip ci] ([4e779a6](4e779a6))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

Assignees

@hacdias hacdias

Labels
None yet
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hacdias @lidel