Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker image build fails for master #10276

Closed
lidel opened this issue Jan 4, 2024 · 3 comments
Closed

Docker image build fails for master #10276

lidel opened this issue Jan 4, 2024 · 3 comments
Assignees
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up

Comments

@lidel
Copy link
Member

lidel commented Jan 4, 2024

Docker image build for master fails since #10272 was merged:

2024-01-04_01-35

@Jorropo @hacdias I don't think the build run in CI in PR #10272 because docker-image.yml is built and pushed only for master and release tags:

push:
branches:
- 'master'
- 'bifrost-*'
tags:
- 'v*'

IIUC what did run in that PR was only the basic smoke-test from docker-build.yml, but that is only building image for linux-amd64 and not other platforms

fwiw you should be able to manually dispatch the correct job via github UI at https://github.com/ipfs/kubo/actions/workflows/docker-image.yml (with "dockerhub push" set to false):

2024-01-04_01-52

@lidel lidel added kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up labels Jan 4, 2024
@hacdias
Copy link
Member

hacdias commented Jan 4, 2024

I reverted the PR in the meanwhile so that we keep having Docker builds. @Jorropo would you mind making a new PR?

@Jorropo
Copy link
Contributor

Jorropo commented Jan 4, 2024

IIUC what did run in that PR was only the basic smoke-test from docker-build.yml, but that is only building image for linux-amd64 and not other platforms

🤦 thx

@hacdias hacdias removed their assignment Jan 5, 2024
@lidel
Copy link
Member Author

lidel commented Jan 16, 2024

I believe it was fixed by #10278

@lidel lidel closed this as completed Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug A bug in existing code (including security flaws) P1 High: Likely tackled by core team if no one steps up
Projects
No open projects
Archived in project
Development

No branches or pull requests

3 participants