Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version check in/after handshake #166

Closed
jbenet opened this issue Oct 14, 2014 · 2 comments
Closed

Version check in/after handshake #166

jbenet opened this issue Oct 14, 2014 · 2 comments
Labels
help wanted Seeking public contribution on this issue

Comments

@jbenet
Copy link
Member

jbenet commented Oct 14, 2014

Right after the secure channel handshake, ipfs connections should handshake protocol versions. Incompatible versions should not talk to each other.

I think the right way is to:

  • have a semver for the whole protocol*
  • send each other protocol version in the connection handshake
  • if major doesn't match, bail. Accept minor and patch differences.

*(it's possible to use per-service versions, but ipfs is not large enough / network alive enough to warrant that yet, we can revisit then)

note on semver major number

For those unfamiliar with semver, don't think of a semver <major> = 2 as ipfs protocol v2. It's really ipfs protocol 1.<major>.<minor>.<patch> in that a 2.x.x.x IMO means a massive rethinking. (think ipv4 -> ipv6)

@jbenet jbenet added the help wanted Seeking public contribution on this issue label Oct 14, 2014
@whyrusleeping
Copy link
Member

Should reference issue #161 for this.

@jbenet
Copy link
Member Author

jbenet commented Oct 16, 2014

Addressed in #180.

@jbenet jbenet closed this as completed Oct 16, 2014
@aschmahmann aschmahmann mentioned this issue Feb 18, 2021
73 tasks
ariescodescream pushed a commit to ariescodescream/go-ipfs that referenced this issue Oct 23, 2021
@aschmahmann aschmahmann mentioned this issue Dec 1, 2021
80 tasks
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
laurentsenta pushed a commit to laurentsenta/kubo that referenced this issue Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Seeking public contribution on this issue
Projects
None yet
Development

No branches or pull requests

2 participants