Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strage sharness failure in CAR tests #7123

Closed
Stebalien opened this issue Apr 9, 2020 · 2 comments · Fixed by #7154
Closed

Strage sharness failure in CAR tests #7123

Stebalien opened this issue Apr 9, 2020 · 2 comments · Fixed by #7154
Assignees
@ribasushi
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

Error: Unknown command ""$("

https://app.circleci.com/pipelines/github/ipfs/go-ipfs/2385/workflows/312a4b14-636d-4e3a-a327-4cf9ba8db077/jobs/29097
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Apr 9, 2020
@ribasushi
Copy link
Contributor

Spent 2h chasing the wrong problem, the error you see is an incorrect argument pass 🤦

The timeout however is indicative of another problem, I only managed to get it once locally in a slightly different config. Will finish figuring it out + PR tomorrow

@ribasushi ribasushi mentioned this issue Apr 10, 2020
Merged
@Stebalien
Copy link
Member Author

Another case: https://app.circleci.com/pipelines/github/ipfs/go-ipfs/2441/workflows/4c474b78-9880-48d4-9f2d-cc50329a419b/jobs/29650/artifacts

This is after disabling the GC logic. I'm pretty sure it's the FIFO import.

Stebalien added a commit that referenced this issue Apr 14, 2020
@Stebalien
test(sharness): improve CAR tests to remove some potential races
5772ac7 
* Instead of ensuring that we GC nothing, verify that the repo validates.
* Avoid a race between removing the fifos and trying to read from them.
* Avoid all 'bash -c' invocations. Instead, make liberal use of subshells and
  wait.

Hopefully fixes #7123.
@Stebalien Stebalien mentioned this issue Apr 14, 2020
Merged
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@Stebalien
test(sharness): improve CAR tests to remove some potential races
171e794 
* Instead of ensuring that we GC nothing, verify that the repo validates.
* Avoid a race between removing the fifos and trying to read from them.
* Avoid all 'bash -c' invocations. Instead, make liberal use of subshells and
  wait.

Hopefully fixes ipfs#7123.
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
test(sharness): improve CAR tests to remove some potential races
775a925 
* Instead of ensuring that we GC nothing, verify that the repo validates.
* Avoid a race between removing the fifos and trying to read from them.
* Avoid all 'bash -c' invocations. Instead, make liberal use of subshells and
  wait.

Hopefully fixes ipfs#7123.
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@Stebalien
test(sharness): improve CAR tests to remove some potential races
f4ef0be 
* Instead of ensuring that we GC nothing, verify that the repo validates.
* Avoid a race between removing the fifos and trying to read from them.
* Avoid all 'bash -c' invocations. Instead, make liberal use of subshells and
  wait.

Hopefully fixes ipfs#7123.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ribasushi ribasushi

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(sharness): improve CAR tests to remove some potential races ipfs/kubo
2 participants
@Stebalien @ribasushi