Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Subdomain redirect doesn't apply to directory listings #7164

Closed
Stebalien opened this issue Apr 15, 2020 · 1 comment · Fixed by #7165
Closed

Subdomain redirect doesn't apply to directory listings #7164

Stebalien opened this issue Apr 15, 2020 · 1 comment · Fixed by #7165
Assignees
@lidel
Labels
kind/bug A bug in existing code (including security flaws)

Comments

@Stebalien
Copy link
Member

Version information:

v0.5.0-rc2

Description:

When listing a directory with no index file, the subdomain gateway redirect isn't applied.

http://localhost:8080/ipns/dist.ipfs.io/go-ipfs
@Stebalien Stebalien added the kind/bug A bug in existing code (including security flaws) label Apr 15, 2020
@lidel
Copy link
Member

lidel commented Apr 15, 2020

Thanks for bringing this to my attention. Will look into this.
(Good news is that directory listing is generated by go-ipfs, so there is no security concerns, mostly cosmetic one)

lidel added a commit that referenced this issue Apr 15, 2020
@lidel
fix: subdomain redirect for dir CIDs
5ee1295 
Closes #7164

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel mentioned this issue Apr 15, 2020
Merged
lidel added a commit that referenced this issue Apr 15, 2020
@lidel
fix: subdomain redirect for dir CIDs
8290ec1 
Closes #7164

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 6, 2020
@lidel
fix: subdomain redirect for dir CIDs
8e83a6f 
Closes ipfs#7164

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@lidel
fix: subdomain redirect for dir CIDs
a4ae819 
Closes ipfs#7164

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
ralendor pushed a commit to ralendor/go-ipfs that referenced this issue Jun 8, 2020
@lidel
fix: subdomain redirect for dir CIDs
c9f4bb1 
Closes ipfs#7164

License: MIT
Signed-off-by: Marcin Rataj <lidel@lidel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lidel lidel

Labels
kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: subdomain redirect for dir CIDs ipfs/kubo
2 participants
@lidel @Stebalien