Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gateway: add UseInlinedDNSLink flag to config #9243

Closed
lidel opened this issue Sep 1, 2022 · 2 comments · Fixed by #9328
Closed

Gateway: add UseInlinedDNSLink flag to config #9243

lidel opened this issue Sep 1, 2022 · 2 comments · Fixed by #9328
Assignees
@hacdias
Labels
kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up topic/gateway Topic gateway

Comments

@lidel
Copy link
Member

lidel commented Sep 1, 2022 •
edited

See (B) from brave/brave-browser#22927

Current state

Public gateways inline DNSLink names into a single label if X-Forwarded-Proto: https is present (see docs)

  • https://dweb.link/ipns/en.wikipedia-on-ipfs.org → redirect → https://en-wikipedia--on--ipfs-org.ipns.dweb.link/wiki/

Localhost gateway does not do that, it keeps the subdomains as they are:

  • http://localhost:48080/ipns/en.wikipedia-on-ipfs.org → redirect → http://en.wikipedia-on-ipfs.org.ipns.localhost:48080/wiki/

Requested enhancement

Brave team asked for a configuration flag that enables DNSLink name inlining into a single DNS label without switching protocol to https (brave/brave-browser#22927).

Proposed design

Add new optional Flag to Gateway.PublicGateways named UseInlinedDNSLink (disabled by default).
@lidel lidel added kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up labels Sep 1, 2022
@lidel lidel self-assigned this Sep 1, 2022
@lidel lidel added kind/bug A bug in existing code (including security flaws) topic/gateway Topic gateway labels Sep 30, 2022
@lidel
Copy link
Member Author

lidel commented Sep 30, 2022 •
edited

I'm re-classifying this as a bug, because Brave is unable to use inlined names on localhost (without HTTPS), because existing logic is built around around X-Forward-Proto: https.

We agreed this will be fixed in Kubo 0.17.

@lidel lidel mentioned this issue Sep 30, 2022
Closed
@lidel
Copy link
Member Author

lidel commented Sep 30, 2022

@hacdias this is small and sweet thing to work on to warm up :) Let's chat about this next week.

@BigLep BigLep assigned hacdias and unassigned lidel Oct 4, 2022
@hacdias hacdias mentioned this issue Oct 5, 2022
Merged
lidel added a commit that referenced this issue Oct 11, 2022
@hacdias @lidel
fix: add InlineDNSLink flag to PublicGateways config (#9328)
4291d6b 
#9243
Co-authored-by: Marcin Rataj <lidel@lidel.org>
hacdias added a commit to ipfs/boxo that referenced this issue Jan 27, 2023
@hacdias
fix: add InlineDNSLink flag to PublicGateways config (#9328)
84f396d 
ipfs/kubo#9243
Co-authored-by: Marcin Rataj <lidel@lidel.org>

This commit was moved from ipfs/kubo@4291d6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hacdias hacdias

Labels
kind/bug A bug in existing code (including security flaws) kind/enhancement A net-new feature or improvement to an existing feature P1 High: Likely tackled by core team if no one steps up topic/gateway Topic gateway
Projects
No open projects
IPFS Shipyard Team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add InlineDNSLink flag to PublicGateways config ipfs/kubo
2 participants
@lidel @hacdias