New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipfs get doesn't work on files with "]" in the name #9370
Comments
reproduce in old version v0.9.1 |
On the Linux version 0.16.0 I didn't get any errors. |
This is because this problem is specific to MS Windows. Ref. https://learn.microsoft.com/en-us/windows/win32/fileio/naming-a-file:
User-friendly way to resolve this is to
|
hi @Arlodotexe I am looking at this issue but cannot reproduce it. can you please post a stack trace? |
@lidel this is not reproducible on windows. |
@susarlanikhilesh files do not have names they are just bytes, directories have a list of name cid pairs. You need to try to download the folder that contains a file with a |
@lidel the problem is, neither the right square bracket or left square bracket are restricted, and you can in fact have files and folder names contain those. Can we please get them removed from the filter list? I specifically want the brackets preserved and not replaced with underscores because they are an important part of folder naming schemas that will break with them removed or replaced. |
Ah, indeed. Tracked down the Windows-specific sanitization, it is in go-libipfs/tar ( Just like others noted the If anyone with Windows has time to test allowing them does not break |
Checklist
Installation method
ipfs-update or dist.ipfs.tech
Version
Config
Click to expand
Description
Repro steps:
]
in the name.ipfs add -r ./path
ipfs get Qmfoo
on the copied CID.Error: invalid platform path: path components cannot contain any of [<>:"\|?*] : "test file].txt"
It's worth noting that this does not happen with the
[
character.The text was updated successfully, but these errors were encountered: