update go-libp2p to v0.29.0 #10001
Merged
update go-libp2p to v0.29.0 #10001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
update-libp2p-v0281
branch
2 times, most recently
from
64b0ce1
to
d65efdb
Compare
27 tasks
Jorropo
force-pushed
the
update-libp2p-v0281
branch
from
d65efdb
to
446f2aa
Compare
Jorropo
requested changes
Jun 28, 2023
marten-seemann
force-pushed
the
update-libp2p-v0281
branch
from
6f79feb
to
ff36a73
Compare
|
All tests are passing excpet for sharness. Can you take care of that one @Jorropo? |
|
I'll |
hacdias
force-pushed
the
update-libp2p-v0281
branch
from
ff36a73
to
35b8134
Compare
Jorropo
force-pushed
the
update-libp2p-v0281
branch
2 times, most recently
from
24c030e
to
b0d926b
Compare
|
@Jorropo Any chance we can get this PR landed any time soon? |
|
Updated to v0.29.0 |
|
Thanks. We will get this in before the 0.22 RC on 2023-07-20. |
|
Would it make sense to keep this two separate PRs, one updating to v0.28.x and the other one updating to v0.29.x? This would allow us to bisect, should there be any libp2p related problem. |
Closed
Jorropo
force-pushed
the
update-libp2p-v0281
branch
2 times, most recently
from
b375758
to
2bbb278
Compare
Agreed thx, I am merging as two commits within one PR. |
Jorropo
force-pushed
the
update-libp2p-v0281
branch
from
2bbb278
to
048f8e7
Compare
BigLep
reviewed
Jul 21, 2023
Co-authored-by: Jorropo <jorropo.pgm@gmail.com>
Jorropo
force-pushed
the
update-libp2p-v0281
branch
from
d88eb86
to
f7af719
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we're planning to to ship v0.29.0 on time for the next release, I'd like to update to v0.28.1 early in the process, mostly to catch any potential regressions early, and to make sure that we at least get v0.28 in, in case the v0.29 release is delayed.