Add a --no-pin option to ipfs add

[eminence]

Implements a solution for #1908

This PR replaces #1909

[ghost]

I still think this should maybe be called --pin instead, defaulting to true.

[eminence]

Totally reasonable. I'll try to defend the code as implemented by pointing out that seems to be precedent in ipfs for options that, when present, turn off some functionality:

• We have ipfs add --only-hash instead of ipfs add --write=false

(Ok, I admit that's the only example I could find). I don't think I care either way, except that --no-pin seems to be easier to type than --pin=false. I am happy to change this if someone else votes in favor of @lgierth

[jbenet]

i think in this case, we do want --pin=false.

[eminence]

Ok! But one small problem -- In the dev0.4.0 branch, there is no support for having bool options take true/false parameters. For example:

 $ ./ipfs add --pin=false
Error: Option 'pin' takes no arguments, but was passed 'true'

This was added in 107409c, but this commit is not part of the dev0.4.0 branch. Are there any plans to rebase this branch on master?

[rht]

+1 dev0.4.0 rebase @whyrusleeping (this can be done with less risk than other PRs)

[jbenet]

@eminence @whyrusleeping is rebasing dev0.4.0 shortly

[eminence]

Ok, I force pushed a commit, due to the dev0.4.0 rebase. Please take another look. Thanks!

[whyrusleeping]

This LGTM

[jbenet]

is there a way to set the default on the commands lib itself? (am not sure.)

[rht]

There is the js trick !!dopin, don't know if it works in golang.

[jbenet]

This LGTM. i'll merge. we can always improve #1931 (comment) later