Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change link to dist to be under IPNS in readme #2417

Merged
merged 1 commit into from
Feb 29, 2016

Conversation

Kubuxu
Copy link
Member

@Kubuxu Kubuxu commented Feb 27, 2016

Otherwise there is invalid cert error.
License: MIT
Signed-off-by: Jakub Sztandera kubuxu@protonmail.ch

@GitCop
Copy link

GitCop commented Feb 27, 2016

There were the following issues with your Pull Request

  • Commit: c15a5dd
    • Invalid signoff. Commit message must end with
      License: MIT
      Signed-off-by: .* <.*>

We ask for a few features in the commit message for Open Source licensing hygiene and commit message clarity.
git commit --amend can often help you quickly improve the commit message.
Guidelines and a script are available to help in the long run.
Your feedback on GitCop is welcome on this issue.


This message was auto-generated by https://gitcop.com

@Kubuxu
Copy link
Member Author

Kubuxu commented Feb 27, 2016

IDK why gitcop doesn't like that commit message.

@RichardLitt
Copy link
Member

Agreed, that sign off seems fine. cc @chriscool

Shouldn't we fix the dist, rather than repoint through the gateway?

@chriscool
Copy link
Contributor

@Kubuxu could you try to put a blank line just before the "License: MIT" line?

Otherwise there is invalid cert error.

License: MIT
Signed-off-by: Jakub Sztandera <kubuxu@protonmail.ch>
@Kubuxu
Copy link
Member Author

Kubuxu commented Feb 29, 2016

Repointing might be a good idea but you can't do that before bad-cert error.

Repushed this time gitcop is not complaining.

@whyrusleeping
Copy link
Member

we're working on getting a wildcard cert, but this is a decent stopgap until then.

cc @lgierth

@ghost
Copy link

ghost commented Feb 29, 2016

Repoint it to either http:// or https://ipfs.io/ipns/, I'll go through everything with a script once the wildcard cert is up

@RichardLitt
Copy link
Member

In that case, this is RFM.

@whyrusleeping
Copy link
Member

cool, merging. Thanks @Kubuxu!

whyrusleeping added a commit that referenced this pull request Feb 29, 2016
Change link to dist to be under IPNS in readme
@whyrusleeping whyrusleeping merged commit 6cd32b3 into ipfs:master Feb 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants