Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved verbose option to clear subcommand only #2487

Closed
wants to merge 1 commit into from

Conversation

RichardLitt
Copy link
Member

It has no effect on ipfs diag cmds set-time, but is set as an option for ipfs diag cmds. Since it is only used for ipfs diag cmds clear, I deduced that it should be an option for that subcommand.

License: MIT
Signed-off-by: Richard Littauer richard.littauer@gmail.com

License: MIT
Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
@whyrusleeping
Copy link
Member

What? I think you need to take another look at this one... moving that verbose option is not correct

@RichardLitt
Copy link
Member Author

I stand by this - it's not used in the other subcommand, so why is it put as an option there?

@RichardLitt
Copy link
Member Author

Hmm. Not getting a response, for either now. Actually, I only am able to use the verbose flag in the clear API, which does send more stuff back. It doesn't do anything for set-time.

@RichardLitt
Copy link
Member Author

You're right! I was not correct; I had not realised that diag cmds was also a valid command. I have now added it to the HTTP API, here: ipfs-inactive/http-api-spec#72.

Separate grammar PR incoming.

@RichardLitt RichardLitt deleted the feature/move-verbose-option branch April 26, 2016 23:30
@momack2 momack2 added this to Needs Review in ipfs/go-ipfs May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need/review Needs a review
Projects
No open projects
ipfs/go-ipfs
Needs Review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants