Added default values to refs #2582
Conversation
| cmds.BoolOption("unique", "u", "Omit duplicate refs from output."), | ||
| cmds.BoolOption("recursive", "r", "Recursively list links of child nodes."), | ||
| cmds.BoolOption("edges", "e", "Emit edge format.").Default("`<from> -> <to>`"), | ||
| cmds.BoolOption("unique", "u", "Omit duplicate refs from output.").Default(false), |
There was a problem hiding this comment.
do we really need to have Default false on every bool? I think thats implied...
|
@RichardLitt ping |
|
Thanks! Will get to this; haven't forgotten. |
License: MIT Signed-off-by: Richard Littauer <richard.littauer@gmail.com>
RichardLitt
force-pushed
the
feature/refs-defaults
branch
from
1692c21
to
53c05ff
Compare
|
Fixed. I think having |
|
@RichardLitt i think its safe to assume that the default is always false (in go, the default value of any bool is false). |
|
@jbenet thoughts on this? |
|
not sure if they will always be false. makes sense to me but i dont think it's guaranteed. things may change too, so users may opt to specify for sure just in case. |
|
the test failures here appear to be because some of our dockerfile deps no longer work. teamcity is passing because that machine has the early (now broken) layers of the image cached. I'll file an issue to get that fixed but it shouldnt block this PR. |
License: MIT
Signed-off-by: Richard Littauer richard.littauer@gmail.com